Add e2e tests for cdp and deployment-service secret read permissions #9735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katyanna
added
the
minor
linki
reviewed
Aug 13, 2025
| g.It("should deny secret read access to kube-system namespace", func() { | ||
| _, err := client.CoreV1().Secrets(systemSecret.Namespace).Get(context.Background(), systemSecret.Name, metav1.GetOptions{}) | ||
| gomega.Expect(err).To(gomega.MatchError(gomega.ContainSubstring("read operations are forbidden"))) | ||
| }) |
There was a problem hiding this comment.
Hmm, that doesn't add up. First of all, why do we "deny" in both cases? Isn't the point of all this stuff the ability to give permissions on all but one namespace (or some variation of this)? If we want to deny access in all namespaces we could just use RBAC.
Secondly, admission-controller isn't involved in GET requests, so these won't go through admission-controller anyways.
Can we define again what we actually wanted to achieve?
katyanna
force-pushed
the
role-sync-e2e
branch
from
f2e02f8 to
ae33a73
Compare
Signed-off-by: Katyanna Moura <[email protected]>
Though the company language is BrE, kubernetes tools use AmE. This commit sets file name to the same pattern used in the code. Signed-off-by: Katyanna Moura <[email protected]>
Signed-off-by: Katyanna Moura <[email protected]>
Signed-off-by: Katyanna Moura <[email protected]>
Signed-off-by: Katyanna Moura <[email protected]>
Signed-off-by: Katyanna Moura <[email protected]>
katyanna
force-pushed
the
role-sync-e2e
branch
from
ae33a73 to
a35f5ce
Compare
Signed-off-by: Katyanna Moura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds e2e tests to verify that CDP and deployment-service can read secrets from any namespace (including kube-system) and that this permission is later revoked by the Admission Controller.
This test coverage helps validate the secret access workflow end-to-end on the redesign of RBAC for EKS.
Ref.: #8871